Remove BitwiseInt class and tests thereof #2776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
corinnebosley
approved these changes
Oct 10, 2017
Member
|
@dkillick Looks like an example cube in userguide/loading_iris_cubes.rst has gained the attribute: This appears to be a problem elsewhere as well. |
DPeterK
force-pushed
the
remove_bitwise_int
branch
from
79df12c to
77fb914
Compare
Member
|
@dkillick Well there's some cml chaos happening now. This PR is causing some weird problems. |
Member
Author
@corinnebosley you're telling me! |
DPeterK
force-pushed
the
remove_bitwise_int
branch
from
77fb914 to
1552a20
Compare
Member
Author
|
@corinnebosley other than a heap of test timeouts all the tests for this change are passing now too 🌮 Do you want me to spin the timing out job or are you happy as-is? |
Member
|
@dkillick I'm gonna respin it for good measure. I am sure it will pass but I don't like unfinished jobs. They make me tense. |
Member
|
Ta-dah! |
Member
Author
|
@corinnebosley now the tests have passed (!) but the result has not been updated here... |
Member
Author
|
Woop! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the deprecated class
iris.fileformats.pp.BitwiseInt. As @lbdreyer pointed out, this class is used as a base class for_LBProc, so I've also updated the inheritance of that class. Removed tests.Fixes #2646